linux-kernel - Re: [PATCH v2] thinkpad_acpi: Add support for X1 Yoga (2016) Tablet Mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 5 Nov 2016 11:45:22 -0700
From:   Darren Hart <dvhart@...radead.org>
To:     Lyude <lyude@...hat.com>
Cc:     Henrique de Moraes Holschuh <hmh@....eng.br>,
        Henrique de Moraes Holschuh <ibm-acpi@....eng.br>,
        ibm-acpi-devel@...ts.sourceforge.net,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] thinkpad_acpi: Add support for X1 Yoga (2016) Tablet
 Mode

On Thu, Oct 27, 2016 at 03:46:44PM -0400, Lyude wrote:
> For whatever reason, the X1 Yoga doesn't support the normal method of
> querying for tablet mode. Instead of providing the MHKG method under the
> hotkey handle, we're instead given the CMMD method under the EC handle.
> Values on this handle are either 0x1, laptop mode, or 0x6, tablet mode.
> 
> Changes since v1:
> - Clarify kernel output when finding the tablet mode switch

These two lines go below the --- below (they aren't meant to be part of the
permanent commit message). Please see Documentation/SubmittingPatches.

I've queued this to testing as it addresses Henrique's change request. Henrique,
I'll add your Reviewed-by if you send it along, or drop it if you have more
reservations.

Thanks,

-- 
Darren Hart
Intel Open Source Technology Center