[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1924809.LJTn50YVYo@diego>
Date: Tue, 08 Nov 2016 14:26:54 +0100
From: Heiko Stübner <heiko@...ech.de>
To: Elaine Zhang <zhangqing@...k-chips.com>
Cc: mturquette@...libre.com, sboyd@...eaurora.org, xf@...k-chips.com,
rocky.hao@...k-chips.com, huangtao@...k-chips.com,
xxx@...k-chips.com, jay.xu@...k-chips.com,
linux-clk@...r.kernel.org, linux-rockchip@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: rockchip: validity should be checked prior to clock rate change
Hi Elaine,
Am Dienstag, 8. November 2016, 17:10:14 schrieb Elaine Zhang:
> If validity is not checked prior to clock rate change, clk_set_rate(
> cpu_clk, unsupported_rate) will return success, but the real clock rate
> change operation is prohibited in post clock change event. Alough post
> clock change event will report error due to unsupported clock rate is
> set, but this error message is ignored by clock framework.
>
> Signed-off-by: Elaine Zhang <zhangqing@...k-chips.com>
> Signed-off-by: Rocky Hao <rocky.hao@...k-chips.com>
looks good and thanks for catching this. Just a bureaucracy-question regarding
the Signed-off-by lines, before I can apply the patch as I don't really know
how Rocky fits into the picture.
I.e. was he the original patch author (the we should change the from) or a
reviewer/tester for the fixed issue?
Thanks
Heiko
Powered by blists - more mailing lists