linux-kernel - Re: [PATCH] iommu/vt-d: Fix the size calculation of pasid table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1478775772.85722.7.camel@infradead.org>
Date:   Thu, 10 Nov 2016 11:02:52 +0000
From:   David Woodhouse <dwmw2@...radead.org>
To:     Joerg Roedel <joro@...tes.org>
Cc:     Xunlei Pang <xlpang@...hat.com>, iommu@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org,
        Mika Kuoppala <mika.kuoppala@...ux.intel.com>
Subject: Re: [PATCH] iommu/vt-d: Fix the size calculation of pasid table

On Thu, 2016-11-10 at 11:45 +0100, Joerg Roedel wrote:
> Hi David,
> 
> On Sun, Oct 30, 2016 at 06:18:22AM -0600, David Woodhouse wrote:
> > +     /* Start at 2 because it's defined as 1^(1+PSS) */
> 
> This probably means 2^(1+PSS), right?

Or 1 << (1+PSS). Yeah.

> > +     iommu->pasid_max = 2 << ecap_pss(iommu->ecap);
> 
> Otherwise the patch looks good. Do you want to send it upstream yourself
> or should I pick it up?

I'll let it sit in -next for a day or two more once I've fixed the
above, then ask Linus to pull it. Thanks.

-- 
dwmw2
Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (5760 bytes)