linux-kernel - Re: [PATCH v5 1/3] cpuid: cleanup cpuid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161110110052.h34r7le4khdlxxk4@pd.tnic>
Date:   Thu, 10 Nov 2016 12:00:52 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     He Chen <he.chen@...ux.intel.com>
Cc:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org, x86@...nel.org,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>,
        Luwei Kang <luwei.kang@...el.com>,
        Piotr Luc <Piotr.Luc@...el.com>
Subject: Re: [PATCH v5 1/3] cpuid: cleanup cpuid_regs definitions

On Thu, Nov 10, 2016 at 11:45:01AM +0100, Borislav Petkov wrote:
> ERROR: space required after that ',' (ctx:VxV)
> #150: FILE: arch/x86/kernel/cpu/scattered.c:27:
> +               { X86_FEATURE_INTEL_PT,         CPUID_EBX,25, 0x00000007, 0 },
>                                                          ^
> 
> ERROR: space required after that ',' (ctx:VxV)
> #157: FILE: arch/x86/kernel/cpu/scattered.c:34:
> +               { X86_FEATURE_PROC_FEEDBACK,    CPUID_EDX,11, 0x80000007, 0 },

Ah, ignore that one. I see you're fixing them in the next patch.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.