linux-kernel - Re: [PATCH v5 2/3] cpuid: Add a helper in scattered.c to return cpuid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161110110747.t2hn3kynetkuface@pd.tnic>
Date:   Thu, 10 Nov 2016 12:07:47 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     He Chen <he.chen@...ux.intel.com>
Cc:     kvm@...r.kernel.org, linux-kernel@...r.kernel.org, x86@...nel.org,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>,
        Luwei Kang <luwei.kang@...el.com>,
        Piotr Luc <Piotr.Luc@...el.com>
Subject: Re: [PATCH v5 2/3] cpuid: Add a helper in scattered.c to return cpuid

On Wed, Nov 09, 2016 at 07:05:27PM +0800, He Chen wrote:
> Some sparse CPUID leafs are gathered in a fake leaf to save size of
> x86_capability array in current code, but sometimes, kernel or other
> modules (e.g. KVM cpuid enumeration) may need actual hardware leaf

s/cpuid/CPUID/

> information.
> 
> This patch adds a helper get_scattered_cpuid_leaf() to rebuild actual
> CPUID leaf, and it can be called outside by modules.
> 
> Signed-off-by: He Chen <he.chen@...ux.intel.com>

Modulo $Subject and typo above, the code looks ok to me:

Reviewed-by: Borislav Petkov <bp@...e.de>

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.