linux-kernel - Re: [PATCH 1/3] mtd: remove unneeded initializer in mtd_ooblayout_{get, set}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 12 Nov 2016 22:25:38 +0100
From:   Marek Vasut <marek.vasut@...il.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        linux-mtd@...ts.infradead.org
Cc:     Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Richard Weinberger <richard@....at>,
        linux-kernel@...r.kernel.org,
        Cyrille Pitchen <cyrille.pitchen@...el.com>,
        Brian Norris <computersforpeace@...il.com>,
        David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH 1/3] mtd: remove unneeded initializer in
 mtd_ooblayout_{get, set}_bytes()

On 11/09/2016 03:08 AM, Masahiro Yamada wrote:
> There is no need to initialize oobregion and section since they will
> be filled by mtd_ooblayout_find_region().
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>

Reviewed-by: Marek Vasut <marek.vasut@...il.com>

> ---
> 
>  drivers/mtd/mtdcore.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> index d46e4ad..cf85f2b 100644
> --- a/drivers/mtd/mtdcore.c
> +++ b/drivers/mtd/mtdcore.c
> @@ -1274,8 +1274,8 @@ static int mtd_ooblayout_get_bytes(struct mtd_info *mtd, u8 *buf,
>  					    int section,
>  					    struct mtd_oob_region *oobregion))
>  {
> -	struct mtd_oob_region oobregion = { };
> -	int section = 0, ret;
> +	struct mtd_oob_region oobregion;
> +	int section, ret;
>  
>  	ret = mtd_ooblayout_find_region(mtd, start, &section,
>  					&oobregion, iter);
> @@ -1317,8 +1317,8 @@ static int mtd_ooblayout_set_bytes(struct mtd_info *mtd, const u8 *buf,
>  					    int section,
>  					    struct mtd_oob_region *oobregion))
>  {
> -	struct mtd_oob_region oobregion = { };
> -	int section = 0, ret;
> +	struct mtd_oob_region oobregion;
> +	int section, ret;
>  
>  	ret = mtd_ooblayout_find_region(mtd, start, &section,
>  					&oobregion, iter);
> 


-- 
Best regards,
Marek Vasut