linux-kernel - Re: [PATCH 2/3] mtd: use min_t() to refactor mtd_ooblayout_{get, set}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b1d59ca4-17c1-872e-fe2e-1471ebd678a4@gmail.com>
Date:   Sat, 12 Nov 2016 22:27:47 +0100
From:   Marek Vasut <marek.vasut@...il.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        linux-mtd@...ts.infradead.org
Cc:     Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Richard Weinberger <richard@....at>,
        linux-kernel@...r.kernel.org,
        Cyrille Pitchen <cyrille.pitchen@...el.com>,
        Brian Norris <computersforpeace@...il.com>,
        David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH 2/3] mtd: use min_t() to refactor mtd_ooblayout_{get,
 set}_bytes()

On 11/09/2016 03:08 AM, Masahiro Yamada wrote:
> I hope this will make the code a little more readable.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>

Reviewed-by: Marek Vasut <marek.vasut@...il.com>

> ---
> 
>  drivers/mtd/mtdcore.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> index cf85f2b..ca6a89a 100644
> --- a/drivers/mtd/mtdcore.c
> +++ b/drivers/mtd/mtdcore.c
> @@ -1283,7 +1283,7 @@ static int mtd_ooblayout_get_bytes(struct mtd_info *mtd, u8 *buf,
>  	while (!ret) {
>  		int cnt;
>  
> -		cnt = oobregion.length > nbytes ? nbytes : oobregion.length;
> +		cnt = min_t(int, nbytes, oobregion.length);
>  		memcpy(buf, oobbuf + oobregion.offset, cnt);
>  		buf += cnt;
>  		nbytes -= cnt;
> @@ -1326,7 +1326,7 @@ static int mtd_ooblayout_set_bytes(struct mtd_info *mtd, const u8 *buf,
>  	while (!ret) {
>  		int cnt;
>  
> -		cnt = oobregion.length > nbytes ? nbytes : oobregion.length;
> +		cnt = min_t(int, nbytes, oobregion.length);
>  		memcpy(oobbuf + oobregion.offset, buf, cnt);
>  		buf += cnt;
>  		nbytes -= cnt;
> 


-- 
Best regards,
Marek Vasut