linux-kernel - Re: [PATCH 10/11] mtd: nand: denali: remove unneeded parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 12 Nov 2016 22:41:22 +0100
From:   Marek Vasut <marek.vasut@...il.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        linux-mtd@...ts.infradead.org
Cc:     Alan Cox <alan@...ux.intel.com>,
        David Woodhouse <David.Woodhouse@...el.com>,
        Jason Roberts <jason.e.roberts@...el.com>,
        Chuanxiao Dong <chuanxiao.dong@...el.com>,
        Dinh Nguyen <dinguyen@...era.com>,
        linux-kernel@...r.kernel.org,
        Boris Brezillon <boris.brezillon@...e-electrons.com>,
        Brian Norris <computersforpeace@...il.com>,
        Richard Weinberger <richard@....at>,
        David Woodhouse <dwmw2@...radead.org>,
        Cyrille Pitchen <cyrille.pitchen@...el.com>
Subject: Re: [PATCH 10/11] mtd: nand: denali: remove unneeded parentheses

On 11/09/2016 05:35 AM, Masahiro Yamada wrote:
> Remove parentheses surrounding the whole right side of an assignment.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>

Reviewed-by: Marek Vasut <marek.vasut@...il.com>

> ---
> 
>  drivers/mtd/nand/denali.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
> index d482d8d..14e66ab 100644
> --- a/drivers/mtd/nand/denali.c
> +++ b/drivers/mtd/nand/denali.c
> @@ -1510,16 +1510,16 @@ int denali_init(struct denali_nand_info *denali)
>  	 * the real pagesize and anything necessery
>  	 */
>  	denali->devnum = ioread32(denali->flash_reg + DEVICES_CONNECTED);
> -	denali->nand.chipsize <<= (denali->devnum - 1);
> -	denali->nand.page_shift += (denali->devnum - 1);
> +	denali->nand.chipsize <<= denali->devnum - 1;
> +	denali->nand.page_shift += denali->devnum - 1;
>  	denali->nand.pagemask = (denali->nand.chipsize >>
>  						denali->nand.page_shift) - 1;
> -	denali->nand.bbt_erase_shift += (denali->devnum - 1);
> +	denali->nand.bbt_erase_shift += denali->devnum - 1;
>  	denali->nand.phys_erase_shift = denali->nand.bbt_erase_shift;
> -	denali->nand.chip_shift += (denali->devnum - 1);
> -	mtd->writesize <<= (denali->devnum - 1);
> -	mtd->oobsize <<= (denali->devnum - 1);
> -	mtd->erasesize <<= (denali->devnum - 1);
> +	denali->nand.chip_shift += denali->devnum - 1;
> +	mtd->writesize <<= denali->devnum - 1;
> +	mtd->oobsize <<= denali->devnum - 1;
> +	mtd->erasesize <<= denali->devnum - 1;

I won't claim I completely understand what this code does, but it
certainly does raise some eyebrows.

>  	mtd->size = denali->nand.numchips * denali->nand.chipsize;
>  	denali->bbtskipbytes *= denali->devnum;
>  
> 


-- 
Best regards,
Marek Vasut