linux-kernel - Re: [PATCH 08/11] mtd: nand: denali: return error code from devm_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2e07f61f-1d93-cb41-f3b7-81481c058a5e@gmail.com>
Date:   Sat, 12 Nov 2016 22:39:46 +0100
From:   Marek Vasut <marek.vasut@...il.com>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>,
        linux-mtd@...ts.infradead.org
Cc:     Boris Brezillon <boris.brezillon@...e-electrons.com>,
        David Woodhouse <David.Woodhouse@...el.com>,
        Richard Weinberger <richard@....at>,
        Jason Roberts <jason.e.roberts@...el.com>,
        linux-kernel@...r.kernel.org,
        Chuanxiao Dong <chuanxiao.dong@...el.com>,
        Cyrille Pitchen <cyrille.pitchen@...el.com>,
        Brian Norris <computersforpeace@...il.com>,
        David Woodhouse <dwmw2@...radead.org>,
        Dinh Nguyen <dinguyen@...era.com>,
        Alan Cox <alan@...ux.intel.com>
Subject: Re: [PATCH 08/11] mtd: nand: denali: return error code from
 devm_request_irq() on error

On 11/09/2016 05:35 AM, Masahiro Yamada wrote:
> The devm_request_irq() returns an appropriate error value when it
> fails.  Use it instead of the fixed -ENODEV.
> 
> While we are here, reword the comment to make it fit in a single
> line, fixing the misspelling of "initialization".
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> ---
> 
>  drivers/mtd/nand/denali.c | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
> index 44e075a..f188a48 100644
> --- a/drivers/mtd/nand/denali.c
> +++ b/drivers/mtd/nand/denali.c
> @@ -1451,14 +1451,12 @@ int denali_init(struct denali_nand_info *denali)
>  	denali_hw_init(denali);
>  	denali_drv_init(denali);
>  
> -	/*
> -	 * denali_isr register is done after all the hardware
> -	 * initilization is finished
> -	 */
> -	if (devm_request_irq(denali->dev, denali->irq, denali_isr, IRQF_SHARED,
> -			     DENALI_NAND_NAME, denali)) {
> +	/* request IRQ after all the hardware initialization is finished */

You can use capital letter to start the sentence -- Request ....

Otherwise:
Reviewed-by: Marek Vasut <marek.vasut@...il.com>

> +	ret = devm_request_irq(denali->dev, denali->irq, denali_isr,
> +			       IRQF_SHARED, DENALI_NAND_NAME, denali);
> +	if (ret) {
>  		dev_err(denali->dev, "Unable to request IRQ\n");
> -		return -ENODEV;
> +		return ret;
>  	}
>  
>  	/* now that our ISR is registered, we can enable interrupts */
> 


-- 
Best regards,
Marek Vasut