linux-kernel - Re: [PATCH v4 09/26] staging: iio: tsl2583: fix alignment of #define values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <74ca5a26-9af9-f876-0261-a8748b62c5e2@kernel.org>
Date:   Sun, 13 Nov 2016 12:13:40 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Brian Masney <masneyb@...tation.org>, linux-iio@...r.kernel.org
Cc:     devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
        lars@...afoo.de, pmeerw@...erw.net, knaack.h@....de,
        linux-kernel@...r.kernel.org, Jon.Brenner@....com
Subject: Re: [PATCH v4 09/26] staging: iio: tsl2583: fix alignment of #define
 values

On 12/11/16 18:19, Brian Masney wrote:
> Most of the values in the #defines have their values aligned on a single
> column, but some do not. This changes the remaining defines to use
> consistent alignment with the majority to improve code readability.
> 
> Signed-off-by: Brian Masney <masneyb@...tation.org>
Applied.
> ---
>  drivers/staging/iio/light/tsl2583.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c
> index 5a82a26..d482a84 100644
> --- a/drivers/staging/iio/light/tsl2583.c
> +++ b/drivers/staging/iio/light/tsl2583.c
> @@ -44,19 +44,19 @@
>  /* tsl2583 cmd reg masks */
>  #define TSL2583_CMD_REG			0x80
>  #define TSL2583_CMD_SPL_FN		0x60
> -#define TSL2583_CMD_ALS_INT_CLR	0X01
> +#define TSL2583_CMD_ALS_INT_CLR		0x01
>  
>  /* tsl2583 cntrl reg masks */
> -#define TSL2583_CNTL_ADC_ENBL	0x02
> +#define TSL2583_CNTL_ADC_ENBL		0x02
>  #define TSL2583_CNTL_PWR_OFF		0x00
>  #define TSL2583_CNTL_PWR_ON		0x01
>  
>  /* tsl2583 status reg masks */
> -#define TSL2583_STA_ADC_VALID	0x01
> -#define TSL2583_STA_ADC_INTR	0x10
> +#define TSL2583_STA_ADC_VALID		0x01
> +#define TSL2583_STA_ADC_INTR		0x10
>  
>  /* Lux calculation constants */
> -#define	TSL2583_LUX_CALC_OVER_FLOW		65535
> +#define	TSL2583_LUX_CALC_OVER_FLOW	65535
>  
>  #define TSL2583_INTERRUPT_DISABLED	0x00
>  
>