linux-kernel - Re: [PATCH v4 10/26] staging: iio: tsl2583: fix comparison between signed and unsigned integers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 13 Nov 2016 12:14:34 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Brian Masney <masneyb@...tation.org>, linux-iio@...r.kernel.org
Cc:     devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
        lars@...afoo.de, pmeerw@...erw.net, knaack.h@....de,
        linux-kernel@...r.kernel.org, Jon.Brenner@....com
Subject: Re: [PATCH v4 10/26] staging: iio: tsl2583: fix comparison between
 signed and unsigned integers

On 12/11/16 18:19, Brian Masney wrote:
> Fixed warning found by make W=2:
> 
> warning: comparison between signed and unsigned integer expressions
> [-Wsign-compare]
> 
> Signed-off-by: Brian Masney <masneyb@...tation.org>
Applied.
> ---
>  drivers/staging/iio/light/tsl2583.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c
> index d482a84..be3cbae 100644
> --- a/drivers/staging/iio/light/tsl2583.c
> +++ b/drivers/staging/iio/light/tsl2583.c
> @@ -510,7 +510,7 @@ static ssize_t in_illuminance_lux_table_show(struct device *dev,
>  					     struct device_attribute *attr,
>  					     char *buf)
>  {
> -	int i;
> +	unsigned int i;
>  	int offset = 0;
>  
>  	for (i = 0; i < ARRAY_SIZE(tsl2583_device_lux); i++) {
> @@ -541,7 +541,8 @@ static ssize_t in_illuminance_lux_table_store(struct device *dev,
>  	struct iio_dev *indio_dev = dev_to_iio_dev(dev);
>  	struct tsl2583_chip *chip = iio_priv(indio_dev);
>  	int value[ARRAY_SIZE(tsl2583_device_lux) * 3 + 1];
> -	int n, ret = -EINVAL;
> +	int ret = -EINVAL;
> +	unsigned int n;
>  
>  	mutex_lock(&chip->als_mutex);
>  
> @@ -719,7 +720,7 @@ static int tsl2583_write_raw(struct iio_dev *indio_dev,
>  		break;
>  	case IIO_CHAN_INFO_CALIBSCALE:
>  		if (chan->type == IIO_LIGHT) {
> -			int i;
> +			unsigned int i;
>  
>  			for (i = 0; i < ARRAY_SIZE(gainadj); i++) {
>  				if (gainadj[i].mean == val) {
>