linux-kernel - Re: [PATCH v4 17/26] staging: iio: tsl2583: remove unnecessary parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1ffdb5cc-5211-92f1-87c9-015b175b2ee5@kernel.org>
Date:   Sun, 13 Nov 2016 12:22:26 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Brian Masney <masneyb@...tation.org>, linux-iio@...r.kernel.org
Cc:     devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
        lars@...afoo.de, pmeerw@...erw.net, knaack.h@....de,
        linux-kernel@...r.kernel.org, Jon.Brenner@....com
Subject: Re: [PATCH v4 17/26] staging: iio: tsl2583: remove unnecessary
 parentheses

On 12/11/16 18:19, Brian Masney wrote:
> in_illuminance_lux_table_store() contains some unnecessary parentheses.
> This patch removes them since they provide no value.
> 
> Signed-off-by: Brian Masney <masneyb@...tation.org>
Applied.
> ---
>  drivers/staging/iio/light/tsl2583.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c
> index fc58074..fe9d777 100644
> --- a/drivers/staging/iio/light/tsl2583.c
> +++ b/drivers/staging/iio/light/tsl2583.c
> @@ -574,7 +574,7 @@ static ssize_t in_illuminance_lux_table_store(struct device *dev,
>  			__func__, TSL2583_MAX_LUX_INTS);
>  		goto done;
>  	}
> -	if ((value[(n - 2)] | value[(n - 1)] | value[n]) != 0) {
> +	if ((value[n - 2] | value[n - 1] | value[n]) != 0) {
>  		dev_err(dev, "%s: The last 3 entries in the lux table must be zeros.\n",
>  			__func__);
>  		goto done;
> @@ -582,7 +582,7 @@ static ssize_t in_illuminance_lux_table_store(struct device *dev,
>  
>  	/* Zero out the table */
>  	memset(tsl2583_device_lux, 0, sizeof(tsl2583_device_lux));
> -	memcpy(tsl2583_device_lux, &value[1], (value[0] * 4));
> +	memcpy(tsl2583_device_lux, &value[1], value[0] * 4);
>  
>  	ret = len;
>  
>