linux-kernel - Re: [PATCH v4 16/26] staging: iio: tsl2583: change tsl2583_als

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eb31f56e-9799-4307-4304-1e91cc536b5e@kernel.org>
Date:   Sun, 13 Nov 2016 12:21:28 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Brian Masney <masneyb@...tation.org>, linux-iio@...r.kernel.org
Cc:     devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
        lars@...afoo.de, pmeerw@...erw.net, knaack.h@....de,
        linux-kernel@...r.kernel.org, Jon.Brenner@....com
Subject: Re: [PATCH v4 16/26] staging: iio: tsl2583: change
 tsl2583_als_calibrate() to return 0 on success

On 12/11/16 18:19, Brian Masney wrote:
> tsl2583_als_calibrate() returns the newly computed gain_trim if the
> calibration was successful. This function is only called by
> in_illuminance_calibrate_store() and the return value inside that
> sysfs attribute is only checked to see if an error was returned.
> This patch changes tsl2583_als_calibrate() to return 0 on success.
> 
> Signed-off-by: Brian Masney <masneyb@...tation.org>
Applied.
> ---
>  drivers/staging/iio/light/tsl2583.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c
> index bcdf095..fc58074 100644
> --- a/drivers/staging/iio/light/tsl2583.c
> +++ b/drivers/staging/iio/light/tsl2583.c
> @@ -348,7 +348,7 @@ static int tsl2583_als_calibrate(struct iio_dev *indio_dev)
>  
>  	chip->als_settings.als_gain_trim = (int)gain_trim_val;
>  
> -	return (int)gain_trim_val;
> +	return 0;
>  }
>  
>  static int tsl2583_set_als_time(struct tsl2583_chip *chip)
>