linux-kernel - Re: [PATCH v4 21/26] staging: iio: tsl2583: clarified comment about clearing interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d728b522-3766-3ad6-7086-0f7cc8c059dc@kernel.org>
Date:   Sun, 13 Nov 2016 12:28:50 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Brian Masney <masneyb@...tation.org>, linux-iio@...r.kernel.org
Cc:     devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
        lars@...afoo.de, pmeerw@...erw.net, knaack.h@....de,
        linux-kernel@...r.kernel.org, Jon.Brenner@....com
Subject: Re: [PATCH v4 21/26] staging: iio: tsl2583: clarified comment about
 clearing interrupts

On 12/11/16 18:19, Brian Masney wrote:
> The comment that describes the code that clears the interrupt bit was
> vague and didn't provide much value. This patch adds more detail about
> why that bit needs to be cleared.
> 
> Signed-off-by: Brian Masney <masneyb@...tation.org>
Applied.
> ---
>  drivers/staging/iio/light/tsl2583.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c
> index 806cb0a..727ed49 100644
> --- a/drivers/staging/iio/light/tsl2583.c
> +++ b/drivers/staging/iio/light/tsl2583.c
> @@ -205,8 +205,9 @@ static int tsl2583_get_lux(struct iio_dev *indio_dev)
>  	}
>  
>  	/*
> -	 * clear status, really interrupt status (interrupts are off), but
> -	 * we use the bit anyway - don't forget 0x80 - this is a command
> +	 * Clear the pending interrupt status bit on the chip to allow the next
> +	 * integration cycle to start. This has to be done even though this
> +	 * driver currently does not support interrupts.
>  	 */
>  	ret = i2c_smbus_write_byte(chip->client,
>  				   (TSL2583_CMD_REG | TSL2583_CMD_SPL_FN |
>