linux-kernel - Re: [PATCH v4 23/26] staging: iio: tsl2583: remove unnecessary memset call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ca76ab8-17b8-9944-82d0-1517b7db91b3@kernel.org>
Date:   Sun, 13 Nov 2016 12:29:38 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Brian Masney <masneyb@...tation.org>, linux-iio@...r.kernel.org
Cc:     devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
        lars@...afoo.de, pmeerw@...erw.net, knaack.h@....de,
        linux-kernel@...r.kernel.org, Jon.Brenner@....com
Subject: Re: [PATCH v4 23/26] staging: iio: tsl2583: remove unnecessary memset
 call

On 12/11/16 18:19, Brian Masney wrote:
> The entries in the lux table (als_device_lux) can be updated via sysfs
> through the function in_illuminance_lux_table_store(). The last row in
> the table must be terminated with values that are zero. The sysfs code
> already ensures that the last row is all zeros. The call to memset to
> clear out the table is not needed so this patch removes the unnecessary
> call.
> 
> Signed-off-by: Brian Masney <masneyb@...tation.org>
Applied.
> ---
>  drivers/staging/iio/light/tsl2583.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/staging/iio/light/tsl2583.c b/drivers/staging/iio/light/tsl2583.c
> index 9db191f..712f753 100644
> --- a/drivers/staging/iio/light/tsl2583.c
> +++ b/drivers/staging/iio/light/tsl2583.c
> @@ -591,9 +591,6 @@ static ssize_t in_illuminance_lux_table_store(struct device *dev,
>  		goto done;
>  	}
>  
> -	/* Zero out the table */
> -	memset(chip->als_settings.als_device_lux, 0,
> -	       sizeof(chip->als_settings.als_device_lux));
>  	memcpy(chip->als_settings.als_device_lux, &value[1],
>  	       value[0] * sizeof(value[1]));
>  
>