lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 13 Nov 2016 11:31:59 -0800 From: Steve Muckle <smuckle.linux@...il.com> To: "Rafael J. Wysocki" <rafael@...nel.org> Cc: Viresh Kumar <viresh.kumar@...aro.org>, Rafael Wysocki <rjw@...ysocki.net>, Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>, Lists linaro-kernel <linaro-kernel@...ts.linaro.org>, Linux PM <linux-pm@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Vincent Guittot <vincent.guittot@...aro.org>, Juri Lelli <Juri.Lelli@....com>, Robin Randhawa <robin.randhawa@....com> Subject: Re: [PATCH 2/3] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task On Fri, Nov 11, 2016 at 11:16:59PM +0100, Rafael J. Wysocki wrote: > > + struct sched_param param = { .sched_priority = 50 }; > > I'd define a symbol for the 50. It's just one extra line of code ... A minor point for sure, but in general what's the motivation for defining symbols for things which are only used once? It makes it harder to untangle and learn a piece of code IMO, having to jump to the definitions of them to see what they are. thanks, Steve
Powered by blists - more mailing lists