[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5829D1C7.9020105@rock-chips.com>
Date: Mon, 14 Nov 2016 23:01:27 +0800
From: Caesar Wang <wxt@...k-chips.com>
To: Heiko Stuebner <heiko@...ech.de>
CC: Caesar Wang <wxt@...k-chips.com>,
Mark Rutland <mark.rutland@....com>,
devicetree@...r.kernel.org,
Elaine Zhang <zhangqing@...k-chips.com>,
Catalin Marinas <catalin.marinas@....com>,
Brian Norris <briannorris@...omium.org>,
Ziyuan Xu <xzy.xu@...k-chips.com>,
Will Deacon <will.deacon@....com>,
Douglas Anderson <dianders@...omium.org>,
Rob Herring <robh+dt@...nel.org>, tfiga@...omium.org,
"open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>,
eddie.cai@...k-chips.com, linux-arm-kernel@...ts.infradead.org,
David Wu <david.wu@...k-chips.com>,
Jianqun Xu <jay.xu@...k-chips.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/9] arm64: dts: rockchip: add eMMC's power domain
support for rk3399
On 2016年11月14日 22:45, Heiko Stuebner wrote:
> Am Mittwoch, 9. November 2016, 21:21:53 CET schrieb Caesar Wang:
>> From: Ziyuan Xu <xzy.xu@...k-chips.com>
>>
>> Control power domain for eMMC via genpd to reduce power consumption.
>>
>> Signed-off-by: Elaine Zhang <zhangqing@...k-chips.com>
>> Signed-off-by: Ziyuan Xu <xzy.xu@...k-chips.com>
>> Signed-off-by: Caesar Wang <wxt@...k-chips.com>
> Authorship / Signed-off mismatch. From above suggest Ziyuan is the author
> while first Signed-off-by indicates Elaine as author. Please clarify.
I believe the Elaine is the first author. Sorry for this kind of
question to brother you again. :(
-
Caesar
>
> Thanks
> Heiko
>
>> ---
>>
>> Changes in v2:
>> - Reviewed-on: https://chromium-review.googlesource.com/376558
>> - Verified on ChromeOS kernel4.4
>>
>> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 11 +++++++++++
>> 1 file changed, 11 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index cbb7f8b..b401176 100644
>> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
>> @@ -269,6 +269,7 @@
>> #clock-cells = <0>;
>> phys = <&emmc_phy>;
>> phy-names = "phy_arasan";
>> + power-domains = <&power RK3399_PD_EMMC>;
>> status = "disabled";
>> };
>>
>> @@ -690,6 +691,11 @@
>> status = "disabled";
>> };
>>
>> + qos_emmc: qos@...58000 {
>> + compatible = "syscon";
>> + reg = <0x0 0xffa58000 0x0 0x20>;
>> + };
>> +
>> qos_gmac: qos@...5c000 {
>> compatible = "syscon";
>> reg = <0x0 0xffa5c000 0x0 0x20>;
>> @@ -823,6 +829,11 @@
>> };
>>
>> /* These power domains are grouped by VD_LOGIC */
>> + pd_emmc@...399_PD_EMMC {
>> + reg = <RK3399_PD_EMMC>;
>> + clocks = <&cru ACLK_EMMC>;
>> + pm_qos = <&qos_emmc>;
>> + };
>> pd_gmac@...399_PD_GMAC {
>> reg = <RK3399_PD_GMAC>;
>> clocks = <&cru ACLK_GMAC>;
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
--
caesar wang | software engineer | wxt@...k-chip.com
Powered by blists - more mailing lists