linux-kernel - Re: [PATCH 1/4] staging: wlan-ng: use GENMASK macro in different defines of hfa384x.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161115122153.GO28701@mwanda>
Date:   Tue, 15 Nov 2016 15:21:54 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Sergio Paracuellos <sergio.paracuellos@...il.com>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] staging: wlan-ng: use GENMASK macro in different
 defines of hfa384x.h

On Thu, Nov 10, 2016 at 07:16:39PM +0100, Sergio Paracuellos wrote:
> +#define		HFA384x_CMD_AINFO		((u16)GENMASK(14, 8))

The casts to u16 are pointless because of type promotion and half of
these defines aren't used anyway (both that I looked at).

regards,
dan carpenter