linux-kernel - Re: [PATCH] HID: udraw-ps3: accel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1479217102.5750.19.camel@hadess.net>
Date:   Tue, 15 Nov 2016 14:38:22 +0100
From:   Bastien Nocera <hadess@...ess.net>
To:     Jiri Kosina <jikos@...nel.org>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HID: udraw-ps3: accel_limits is local to the driver

On Tue, 2016-11-15 at 14:26 +0100, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@...e.cz>
> 
> And as such should be marked static to avoid global namespace
> pollution.
> 
> Signed-off-by: Jiri Kosina <jkosina@...e.cz>

Yes, thanks.

Reviewed-by: Bastien Nocera <hadess@...ess.net>

> ---
> 
> I've just applied this on top of hid.git#for-4.10/udraw-ps3
> 
>  drivers/hid/hid-udraw-ps3.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-udraw-ps3.c b/drivers/hid/hid-udraw-
> ps3.c
> index 1f68b0b..88ea390 100644
> --- a/drivers/hid/hid-udraw-ps3.c
> +++ b/drivers/hid/hid-udraw-ps3.c
> @@ -54,7 +54,7 @@ enum {
>   * Accelerometer min/max values
>   * in order, X, Y and Z
>   */
> -struct {
> +static struct {
>         int min;
>         int max;
>  } accel_limits[] = {
> 
> -- 
> Jiri Kosina
> SUSE Labs
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-
> input" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html