linux-kernel - [PATCH] thunderbolt: fix compile-test dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 15 Nov 2016 16:58:53 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Andreas Noever <andreas.noever@...il.com>
Cc:     Arnd Bergmann <arnd@...db.de>, Lukas Wunner <lukas@...ner.de>,
        Matt Fleming <matt@...eblueprint.co.uk>,
        Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org
Subject: [PATCH] thunderbolt: fix compile-test dependencies

Building the Apple thunderbolt driver on non-x86 machines now produces
a harmless warning:

warning: (THUNDERBOLT) selects APPLE_PROPERTIES which has unmet direct dependencies (EFI && EFI_STUB && X86)

As there is no compile-time dependency to the Apple properties support,
we can make that 'select' statement conditional on the dependencies
of that driver.

Fixes: c9cc3aaa0281 ("thunderbolt: Use Device ROM retrieved from EFI")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 drivers/thunderbolt/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/thunderbolt/Kconfig b/drivers/thunderbolt/Kconfig
index 0056df7f3c09..4e7d92193b65 100644
--- a/drivers/thunderbolt/Kconfig
+++ b/drivers/thunderbolt/Kconfig
@@ -1,7 +1,8 @@
 menuconfig THUNDERBOLT
 	tristate "Thunderbolt support for Apple devices"
+	depends on (EFI_STUB && X86) || COMPILE_TEST
 	depends on PCI
-	select APPLE_PROPERTIES
+	select APPLE_PROPERTIES if (X86 && EFI_STUB)
 	select CRC32
 	help
 	  Cactus Ridge Thunderbolt Controller driver
-- 
2.9.0