linux-kernel - Re: [PATCH] thunderbolt: fix compile-test dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161115162134.GA10928@wunner.de>
Date:   Tue, 15 Nov 2016 17:21:34 +0100
From:   Lukas Wunner <lukas@...ner.de>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Andreas Noever <andreas.noever@...il.com>,
        Matt Fleming <matt@...eblueprint.co.uk>,
        Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] thunderbolt: fix compile-test dependencies

On Tue, Nov 15, 2016 at 04:58:53PM +0100, Arnd Bergmann wrote:
> Building the Apple thunderbolt driver on non-x86 machines now produces
> a harmless warning:
> 
> warning: (THUNDERBOLT) selects APPLE_PROPERTIES which has unmet direct dependencies (EFI && EFI_STUB && X86)
> 
> As there is no compile-time dependency to the Apple properties support,
> we can make that 'select' statement conditional on the dependencies
> of that driver.

Thanks Arnd, a commit fixing this is already on the tip.git efi/core
branch since this morning and will hopefully have landed in linux-next
by tomorrow:
http://git.kernel.org/tip/79f9cd35b05e3e91ccf9b4038a8b74b9362b5da7

Previous discussion on LKML:
https://lkml.org/lkml/2016/11/14/456

Another comment below...

> 
> Fixes: c9cc3aaa0281 ("thunderbolt: Use Device ROM retrieved from EFI")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/thunderbolt/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/thunderbolt/Kconfig b/drivers/thunderbolt/Kconfig
> index 0056df7f3c09..4e7d92193b65 100644
> --- a/drivers/thunderbolt/Kconfig
> +++ b/drivers/thunderbolt/Kconfig
> @@ -1,7 +1,8 @@
>  menuconfig THUNDERBOLT
>  	tristate "Thunderbolt support for Apple devices"
> +	depends on (EFI_STUB && X86) || COMPILE_TEST

This addition isn't correct, the thunderbolt driver works without
the EFI stub, it just falls back to a hardcoded Device ROM.

In other words, using the Device ROM retrieved by the EFI stub is
an optional feature that is supposed to be enabled by default in
the config if the EFI stub is also enabled.  That is what the patch
now in tip.git does.

Nevertheless, thanks for your efforts and sorry for having caused
you extra work.

Lukas

>  	depends on PCI
> -	select APPLE_PROPERTIES
> +	select APPLE_PROPERTIES if (X86 && EFI_STUB)
>  	select CRC32
>  	help
>  	  Cactus Ridge Thunderbolt Controller driver
> -- 
> 2.9.0