linux-kernel - Re: [PATCH] printk, locking/atomics, kref: Introduce new %pAr and %pAk format string options for atomic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFz1QBi1Of3UUzc=6HWM7wPe7FaztoxKtCLuneuzu+4=YQ@mail.gmail.com>
Date:   Tue, 15 Nov 2016 08:42:39 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     Greg KH <gregkh@...uxfoundation.org>,
        Christoph Hellwig <hch@...radead.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Kees Cook <keescook@...omium.org>,
        Will Deacon <will.deacon@....com>, elena.reshetova@...el.com,
        Arnd Bergmann <arnd@...db.de>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Anvin <hpa@...or.com>, dave@...gbits.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] printk, locking/atomics, kref: Introduce new %pAr and
 %pAk format string options for atomic_t and 'struct kref'

On Tue, Nov 15, 2016 at 12:37 AM, Ingo Molnar <mingo@...nel.org> wrote:
> +atomic variables such atomic_t or struct kref:
> +
> +       %pAr    atomic_t count
> +       %pAk    struct kref count

Not a huge fan. That "r" makes sense to you ("raw" atomic), but it
makes no sense to a user. An atomic isn't "raw" to anybody else. It's
just an atomic.

Also, we have 'atomic64_t", which this doesn't cover at all.

I'd suggest just %pA, %pA64, %pAkref or something. Which leaves us the
choice to add more atomic versions later without having to make up
random one-letter things that make no sense.

           Linus