linux-kernel - Re: [PATCH] net: ethernet: faraday: To support device tree usage.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161116121618.GC1791@nanopsycho.orion>
Date:   Wed, 16 Nov 2016 13:16:18 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Greentime Hu <green.hu@...il.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: ethernet: faraday: To support device tree usage.

Wed, Nov 16, 2016 at 01:08:57PM CET, green.hu@...il.com wrote:
>You are right. I didn't notice that. I should use ftmac100.

Don't top-post please.


>
>On Wed, Nov 16, 2016 at 7:53 PM, Jiri Pirko <jiri@...nulli.us> wrote:
>> Wed, Nov 16, 2016 at 09:43:15AM CET, green.hu@...il.com wrote:
>>>To support device tree usage for ftmac100.
>>>
>>>Signed-off-by: Greentime Hu <green.hu@...il.com>
>>>---
>>> drivers/net/ethernet/faraday/ftmac100.c |    7 +++++++
>>> 1 file changed, 7 insertions(+)
>>>
>>>diff --git a/drivers/net/ethernet/faraday/ftmac100.c b/drivers/net/ethernet/faraday/ftmac100.c
>>>index dce5f7b..81dd9e1 100644
>>>--- a/drivers/net/ethernet/faraday/ftmac100.c
>>>+++ b/drivers/net/ethernet/faraday/ftmac100.c
>>>@@ -1172,11 +1172,17 @@ static int __exit ftmac100_remove(struct platform_device *pdev)
>>>       return 0;
>>> }
>>>
>>>+static const struct of_device_id mac_of_ids[] = {
>>
>> Prefix of everything in this file is "ftmac100", yet here, you use
>> "mac". I wonder why?!?
>>
>>
>>
>>>+      { .compatible = "andestech,atmac100" },
>>>+      { }
>>>+};
>>>+
>>> static struct platform_driver ftmac100_driver = {
>>>       .probe          = ftmac100_probe,
>>>       .remove         = __exit_p(ftmac100_remove),
>>>       .driver         = {
>>>               .name   = DRV_NAME,
>>>+              .of_match_table = mac_of_ids
>>>       },
>>> };
>>>
>>>@@ -1200,3 +1206,4 @@ static void __exit ftmac100_exit(void)
>>> MODULE_AUTHOR("Po-Yu Chuang <ratbert@...aday-tech.com>");
>>> MODULE_DESCRIPTION("FTMAC100 driver");
>>> MODULE_LICENSE("GPL");
>>>+MODULE_DEVICE_TABLE(of, mac_of_ids);
>>>--
>>>1.7.9.5
>>>