linux-kernel - Re: [PATCH] Support for perf on AMD family17h processors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd06d95-1d43-934c-4112-016f1c076585@amd.com>
Date:   Wed, 16 Nov 2016 14:49:29 -0600
From:   "Natarajan, Janakarajan" <Janakarajan.Natarajan@....com>
To:     Borislav Petkov <bp@...en8.de>
CC:     <linux-kernel@...r.kernel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        "Suravee Suthikulpanit" <suravee.suthikulpanit@....com>
Subject: Re: [PATCH] Support for perf on AMD family17h processors


On 11/16/2016 12:47 PM, Borislav Petkov wrote:
> On Wed, Nov 16, 2016 at 11:01:53AM -0600, Janakarajan Natarajan wrote:
>> This patch enables perf core PMU support for AMD family17h processors.
>> In family17h, there is no PMC-event constraint. All events, irrespective
>> of the type, can be measured using any of the performance counters.
>>
>> Signed-off-by: Janakarajan Natarajan <Janakarajan.Natarajan@....com>
>> ---
>>   arch/x86/events/amd/core.c | 15 ++++++++++++---
>>   1 file changed, 12 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/x86/events/amd/core.c b/arch/x86/events/amd/core.c
>> index f5f4b3f..849688d 100644
>> --- a/arch/x86/events/amd/core.c
>> +++ b/arch/x86/events/amd/core.c
>> @@ -652,7 +652,11 @@ static __initconst const struct x86_pmu amd_pmu = {
>>   	.amd_nb_constraints	= 1,
>>   };
>>   
>> -static int __init amd_core_pmu_init(void)
>> +/*
>> + * This function initializes core PMU to enable support
>> + * for AMD Core PMC Extension.
>> + */
>> +static int __init amd_core_pmc_ext_init(void)
>>   {
>>   	if (!boot_cpu_has(X86_FEATURE_PERFCTR_CORE))
>>   		return 0;
> This renaming looks pretty useless to me. So does the comment.
I'll remove the renaming and comment in a v2 patch.
>