linux-kernel - Re: [PATCH RFC 5/6] selftests: add EXTRA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 18 Nov 2016 20:51:19 +0800
From:   "Zhangjian (Bamvor)" <bamvor.zhangjian@...wei.com>
To:     Michael Ellerman <mpe@...erman.id.au>, <shuahkh@....samsung.com>
CC:     <linux-api@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <khilman@...aro.org>, <broonie@...nel.org>,
        Bamvor Zhang Jian <bamvor.zhangjian@...aro.org>
Subject: Re: [PATCH RFC 5/6] selftests: add EXTRA_CLEAN for clean target

Hi, Micheal

On 2016/11/18 19:01, Michael Ellerman wrote:
> bamvor.zhangjian@...wei.com writes:
>
>> From: Bamvor Jian Zhang <bamvor.zhangjian@...aro.org>
>>
>> Some testcases need the clean extra data after running. This patch
>> introduce the "EXTRA_CLEAN" variable to address this requirement.
>
> The idea here is fine I think. But this will need reworking if you
> follow my suggestions for patch 1.
>
>> After KOUTPUT_BUILD is enabled in later patch, it will be easy to
>> decide to if we need do the cleanup in the KOUTPUT_BUILD path, if the
>> testcase ran immediately after compiled.
>>
>> Signed-off-by: Bamvor Jian Zhang <bamvor.zhangjian@...aro.org>
>
> All of these:
>
>>  tools/testing/selftests/powerpc/benchmarks/Makefile   |  5 ++---
>>  tools/testing/selftests/powerpc/copyloops/Makefile    |  3 +--
>>  tools/testing/selftests/powerpc/dscr/Makefile         |  4 ++--
>>  tools/testing/selftests/powerpc/math/Makefile         |  5 ++---
>>  tools/testing/selftests/powerpc/primitives/Makefile   |  5 ++---
>>  tools/testing/selftests/powerpc/stringloops/Makefile  |  5 ++---
>>  tools/testing/selftests/powerpc/syscalls/Makefile     |  5 ++---
>>  tools/testing/selftests/powerpc/tm/Makefile           |  5 ++---
>
> are just cleaning *.o, and I'm pretty sure none of them need to. So for
> those you can just drop the custom clean rule.
Sorry I do not check these. Because I define the fake target for
testing for ppc. Then I could remove *.o directly in above files.

Regards

Bamvor
>
> This one does need a custom rule:
>
>>  .../testing/selftests/powerpc/switch_endian/Makefile  |  5 ++---
>
>
> cheers
>