linux-kernel - Re: [PATCH RFC 1/6] selftests: remove duplicated all and clean target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1ffc34d0-0a4c-efd3-ed3d-6073b2ea32ac@huawei.com>
Date:   Fri, 18 Nov 2016 20:59:30 +0800
From:   "Zhangjian (Bamvor)" <bamvor.zhangjian@...wei.com>
To:     Michael Ellerman <mpe@...erman.id.au>, <shuahkh@....samsung.com>
CC:     <linux-api@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <khilman@...aro.org>, <broonie@...nel.org>,
        Bamvor Zhang Jian <bamvor.zhangjian@...aro.org>
Subject: Re: [PATCH RFC 1/6] selftests: remove duplicated all and clean target

Hi, Michael

On 2016/11/18 18:31, Michael Ellerman wrote:
 >Hi Bamvor,
 >
 >bamvor.zhangjian@...wei.com writes:
 >
 >> From: Bamvor Jian Zhang <bamvor.zhangjian@...aro.org>
 >>
 >> Currently, kselftest use TEST_PROGS, TEST_PROGS_EXTENDED, TEST_FILES to
 >> indicate the default test program, extended test program and test files.
 >> These lead to duplicated all and clean targets.
 >>
 >> In order to remove them, introduce TEST_GEN_PROGS,
 >> TEST_GEN_PROGS_EXTENDED, TEST_GEN_FILES to indicate the compiled
 >> objected.
 >
 >It's nice to be able to drop the clean rules, but renaming all those
 >variables causes a lot of churn.
 >
 >I think it would be better if we add a new variable, maybe NO_CLEAN,
 >which can be used to specify anything in TEST_PROGS/EXTENDED which
 >should *not* be cleaned.
 >
 >And then the default clean rule will just do:
 >
 >clean:
 >    $(RM) -fr $(filter-out $(NO_CLEAN),$(TEST_PROGS))
Maybe I lost somewhere. I add these variable for all and
clean target. They will be used to output the objects to OUTPUT
directory. Could you please explain in details how should I do it for
"all" target if I do not introduce TEST_GEN_PROGS,
TEST_GEN_PROGS_EXTENDED and TEST_GEN_FILES?

Regards

Bamvor
 >
 >
 >I think that would require less changes overall, because most tests just
 >want to build some files, run them, and then clean them. The tests that
 >need to do more elaborate things are the exception.
 >
 >cheers