linux-kernel - Re: [PATCH] remoteproc: wcnss-pil: add QCOM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161118170549.GB2769@tuxbot>
Date:   Fri, 18 Nov 2016 09:05:49 -0800
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Ohad Ben-Cohen <ohad@...ery.com>,
        Vinod Koul <vinod.koul@...el.com>,
        Peter Griffin <peter.griffin@...aro.org>,
        Lee Jones <lee.jones@...aro.org>,
        linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] remoteproc: wcnss-pil: add QCOM_SMD dependency

On Fri 18 Nov 08:15 PST 2016, Arnd Bergmann wrote:

> When qcom_smd is a loadable module and adsp-pil is built-in,
> we get a link error:
> 
> drivers/remoteproc/qcom_wcnss_pil.o: In function `wcnss_smd_remove':
> qcom_wcnss_iris.c:(.text.wcnss_smd_remove+0x10): undefined reference to `qcom_smd_unregister_edge'
> drivers/remoteproc/qcom_wcnss_pil.o: In function `wcnss_smd_probe':
> qcom_wcnss_iris.c:(.text.wcnss_smd_probe+0x12): undefined reference to `qcom_smd_register_edge'
> 
> This adds a Kconfig dependency to avoid this. We can still allow
> build-testing with SMD disabled.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied

Thanks,
Bjorn

> ---
>  drivers/remoteproc/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index 5a0019ce7555..677b3fede83d 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -106,6 +106,7 @@ config QCOM_Q6V5_PIL
>  config QCOM_WCNSS_PIL
>  	tristate "Qualcomm WCNSS Peripheral Image Loader"
>  	depends on OF && ARCH_QCOM
> +	depends on QCOM_SMD || (COMPILE_TEST && QCOM_SMD = n)
>  	depends on QCOM_SMEM
>  	depends on REMOTEPROC
>  	select QCOM_MDT_LOADER
> -- 
> 2.9.0
>