linux-kernel - Re: [PATCH 1/2] x86/mce: Include the PPIN in machine check records when it is available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <878tsg67r3.fsf@tassilo.jf.intel.com>
Date:   Fri, 18 Nov 2016 09:02:56 -0800
From:   Andi Kleen <andi@...stfloor.org>
To:     Borislav Petkov <bp@...e.de>
Cc:     "Luck\, Tony" <tony.luck@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] x86/mce: Include the PPIN in machine check records when it is available

Borislav Petkov <bp@...e.de> writes:
>
>> @@ -2134,8 +2140,37 @@ static int __init mcheck_enable(char *str)
>>  }
>>  __setup("mce", mcheck_enable);
>>  
>> +static void mcheck_intel_ppin_init(void)
>
> So this functionality could all be moved to arch/x86/kernel/cpu/intel.c
> where you could set an artificial X86_FEATURE_PPIN and get rid of the
> have_ppin var.


That means that a tiny kernel that compiles out machine check
functionality has this unnecessary code.

In general it doesn't make any sense to define a FEATURE flag for
a single user. It's better to just check it where it is needed.

-Andi