linux-kernel - Re: [PATCH] Drop unnecessary pcibio_err_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161118100241.7019379e@t450s.home>
Date:   Fri, 18 Nov 2016 10:02:41 -0700
From:   Alex Williamson <alex.williamson@...hat.com>
To:     Cao jin <caoj.fnst@...fujitsu.com>
Cc:     <linux-kernel@...r.kernel.org>, <kvm@...r.kernel.org>
Subject: Re: [PATCH] Drop unnecessary pcibio_err_to_errno()


Please prefix patches with their functional area, for instance I'll
prepend "vfio/pci" to this.  Had you not cc'd me, I wouldn't have
noticed this patch w/o some mention of vfio in the subject.


On Fri, 18 Nov 2016 19:47:38 +0800
Cao jin <caoj.fnst@...fujitsu.com> wrote:
> pci_user_read/write_config_xxxx() already does the translation.
> 

It would be helpful to mention in the commit where this translation was
added to those functions, d97ffe236894 ("PCI: Fix return value from
pci_user_{read,write}_config_*()")

It's also worthwhile to mention that no change in behavior is expected
since pcibios_err_to_errno() will not mangle existing errno values, the
call is simply unnecessary given the previous conversion.

I'll modify the title and commit log as described and apply.  Thanks,

Alex

> Signed-off-by: Cao jin <caoj.fnst@...fujitsu.com>
> ---
>  drivers/vfio/pci/vfio_pci_config.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/vfio/pci/vfio_pci_config.c b/drivers/vfio/pci/vfio_pci_config.c
> index 65d4a30..e4220ca 100644
> --- a/drivers/vfio/pci/vfio_pci_config.c
> +++ b/drivers/vfio/pci/vfio_pci_config.c
> @@ -152,7 +152,7 @@ static int vfio_user_config_read(struct pci_dev *pdev, int offset,
>  
>  	*val = cpu_to_le32(tmp_val);
>  
> -	return pcibios_err_to_errno(ret);
> +	return ret;
>  }
>  
>  static int vfio_user_config_write(struct pci_dev *pdev, int offset,
> @@ -173,7 +173,7 @@ static int vfio_user_config_write(struct pci_dev *pdev, int offset,
>  		break;
>  	}
>  
> -	return pcibios_err_to_errno(ret);
> +	return ret;
>  }
>  
>  static int vfio_default_config_read(struct vfio_pci_device *vdev, int pos,
> @@ -257,7 +257,7 @@ static int vfio_direct_config_read(struct vfio_pci_device *vdev, int pos,
>  
>  	ret = vfio_user_config_read(vdev->pdev, pos, val, count);
>  	if (ret)
> -		return pcibios_err_to_errno(ret);
> +		return ret;
>  
>  	if (pos >= PCI_CFG_SPACE_SIZE) { /* Extended cap header mangling */
>  		if (offset < 4)
> @@ -295,7 +295,7 @@ static int vfio_raw_config_read(struct vfio_pci_device *vdev, int pos,
>  
>  	ret = vfio_user_config_read(vdev->pdev, pos, val, count);
>  	if (ret)
> -		return pcibios_err_to_errno(ret);
> +		return ret;
>  
>  	return count;
>  }
> @@ -1089,7 +1089,7 @@ static int vfio_msi_config_write(struct vfio_pci_device *vdev, int pos,
>  						 start + PCI_MSI_FLAGS,
>  						 flags);
>  		if (ret)
> -			return pcibios_err_to_errno(ret);
> +			return ret;
>  	}
>  
>  	return count;