linux-kernel - Re: [PATCH V8 3/3] stm: Mark the functions of writing buffer with notrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Nov 2016 10:24:44 +0800
From:   Chunyan Zhang <zhang.chunyan@...aro.org>
To:     Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>, mingo@...hat.com,
        Mike Leach <mike.leach@....com>, Tor Jeremiassen <tor@...com>,
        philippe.langlais@...com, Nicolas GUION <nicolas.guion@...com>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        Lyra Zhang <zhang.lyra@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH V8 3/3] stm: Mark the functions of writing buffer with notrace

On 18 November 2016 at 22:45, Alexander Shishkin
<alexander.shishkin@...ux.intel.com> wrote:
> Chunyan Zhang <zhang.chunyan@...aro.org> writes:
>
>> If CONFIG_STM_SOURCE_FTRACE is selected, Function trace data can be writen
>> to sink via STM, all functions that related to writing data packets to
>> STM should be marked 'notrace' to avoid being traced by Ftrace, otherwise
>> the program would stall into an endless loop.
>>
>> Signed-off-by: Chunyan Zhang <zhang.chunyan@...aro.org>
>> Acked-by: Steven Rostedt <rostedt@...dmis.org>
>> ---
>>  drivers/hwtracing/coresight/coresight-stm.c |  2 +-
>>  drivers/hwtracing/intel_th/sth.c            | 11 +++++++----
>>  drivers/hwtracing/stm/core.c                |  7 ++++---
>>  drivers/hwtracing/stm/dummy_stm.c           |  2 +-
>>  include/linux/stm.h                         |  4 ++--
>>  5 files changed, 15 insertions(+), 11 deletions(-)
>
> Quick nit: can you please split this one in 4: one for Coresight, one
> for Intel TH, one for stm/dummy and one for stm/core?

Sure, will do.

>
> I'd like to keep the bisectability. Otherwise, this is fine by me:
>
> Acked-by: Alexander Shishkin <alexander.shishkin@...ux.intel.com>

Thanks,
Chunyan

>
> Regards,
> --
> Alex