linux-kernel - Re: [PATCH] watchdog: wdat_wdt: Select WATCHDOG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1dbc6c68-3ec7-1f4b-746d-494ffba39311@roeck-us.net>
Date:   Mon, 21 Nov 2016 07:14:08 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Mika Westerberg <mika.westerberg@...ux.intel.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>
Cc:     Vegard Nossum <vegard.nossum@...il.com>,
        Wim Van Sebroeck <wim@...ana.be>, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: wdat_wdt: Select WATCHDOG_CORE

On 11/21/2016 05:33 AM, Mika Westerberg wrote:
> The WDAT watchdog driver uses functionality provided by the watchdog timer
> core but it did not select it explicitly. This results following linker
> error when only WDAT_WDT is enabled in Kconfig:
>
>   drivers/built-in.o: In function `wdat_wdt_probe':
>   drivers/watchdog/wdat_wdt.c:444: undefined reference to `devm_watchdog_register_device'
>
> Fix this by explicitly selecting WATCHDOG_CORE when WDAT watchdog driver is
> enabled.
>
> Fixes: 058dfc767008 (ACPI / watchdog: Add support for WDAT hardware watchdog)
> Reported-by: Vegard Nossum <vegard.nossum@...il.com>
> Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index fdd3228e0678..3eb58cb51e56 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -155,6 +155,7 @@ config TANGOX_WATCHDOG
>  config WDAT_WDT
>  	tristate "ACPI Watchdog Action Table (WDAT)"
>  	depends on ACPI
> +	select WATCHDOG_CORE
>  	select ACPI_WATCHDOG
>  	help
>  	  This driver adds support for systems with ACPI Watchdog Action
>