linux-kernel - Re: [PATCH] watchdog: wdat_wdt: Select WATCHDOG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1813013.KOlSoqaZE7@vostro.rjw.lan>
Date:   Thu, 24 Nov 2016 02:30:43 +0100
From:   "Rafael J. Wysocki" <rjw@...ysocki.net>
To:     Guenter Roeck <linux@...ck-us.net>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>
Cc:     Vegard Nossum <vegard.nossum@...il.com>,
        Wim Van Sebroeck <wim@...ana.be>, linux-acpi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: wdat_wdt: Select WATCHDOG_CORE

On Monday, November 21, 2016 07:14:08 AM Guenter Roeck wrote:
> On 11/21/2016 05:33 AM, Mika Westerberg wrote:
> > The WDAT watchdog driver uses functionality provided by the watchdog timer
> > core but it did not select it explicitly. This results following linker
> > error when only WDAT_WDT is enabled in Kconfig:
> >
> >   drivers/built-in.o: In function `wdat_wdt_probe':
> >   drivers/watchdog/wdat_wdt.c:444: undefined reference to `devm_watchdog_register_device'
> >
> > Fix this by explicitly selecting WATCHDOG_CORE when WDAT watchdog driver is
> > enabled.
> >
> > Fixes: 058dfc767008 (ACPI / watchdog: Add support for WDAT hardware watchdog)
> > Reported-by: Vegard Nossum <vegard.nossum@...il.com>
> > Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> 
> Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> 

Applied.

Thanks,
Rafael