linux-kernel - Re: [PATCHv11 2/3] usb: USB Type-C connector class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161122081942.GA30186@kroah.com>
Date:   Tue, 22 Nov 2016 09:19:42 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Cc:     Guenter Roeck <linux@...ck-us.net>,
        Badhri Jagan Sridharan <badhri@...gle.com>,
        Oliver Neukum <oneukum@...e.com>, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org
Subject: Re: [PATCHv11 2/3] usb: USB Type-C connector class

On Tue, Nov 22, 2016 at 09:58:13AM +0200, Heikki Krogerus wrote:
> Hi Greg,
> 
> On Mon, Nov 21, 2016 at 03:46:08PM +0100, Greg KH wrote:
> > > > > +
> > > > > +config TYPEC
> > > > > +	tristate
> > > > 
> > > > Hah, that says NOTHING about what this code is at all.
> > > 
> > > Alone the class driver does nothing. Why would the user need to be
> > > aware of if it when selecting the Type-C drivers, and what can the
> > > user use that information for?
> > 
> > If you see a blank Kconfig option, what are you supposed to do with it?
> > How do you know if you need to enable it or not?  Are you just supposed
> > to guess?
> 
> But you don't see anything when you are selecting the drivers and that
> is the point. You now can't select this separately. There is now no
> option for it.
> 
> Why should we bother the user with this? The user is most likely only
> interested in the drivers and by selecting those the user will get the
> interface. The drivers will need to have the dependency to the class
> set correctly in any case.

So with this patch, no code gets built or asked about in Kconfig?

Odd, if so, sorry for the noise...

greg k-h