lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 22 Nov 2016 01:45:57 -0800 From: Joe Perches <joe@...ches.com> To: Laxman Dewangan <ldewangan@...dia.com>, Jon Hunter <jonathanh@...dia.com>, linus.walleij@...aro.org, robh+dt@...nel.org, mark.rutland@....com, swarren@...dotorg.org, thierry.reding@...il.com Cc: gnurou@...il.com, yamada.masahiro@...ionext.com, linux-gpio@...r.kernel.org, devicetree@...r.kernel.org, linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH V2 2/2] pinctrl: tegra: Add driver to configure voltage and power of io pads On Tue, 2016-11-22 at 13:45 +0530, Laxman Dewangan wrote: > On Tuesday 22 November 2016 02:31 AM, Jon Hunter wrote: > > On 09/11/16 13:06, Laxman Dewangan wrote: > > + _entry_(32, "uart", UART, true, "vddio-uart"), \ > > + _entry_(33, "usb0", USB0, true, NULL), \ > > + _entry_(34, "usb1", USB1, true, NULL), \ > > + _entry_(35, "usb2", USB2, true, NULL), \ > > + _entry_(36, "usb3", USB3, true, NULL), \ > > + _entry_(37, "usb-bias", USB_BIAS, true, NULL) > > Can you also fix these checkpatch errors ... > > > > ERROR: Macros with complex values should be enclosed in parentheses > > #424: FILE: drivers/pinctrl/tegra/pinctrl-tegra-io-pad.c:350: > > > > ERROR: Macros with complex values should be enclosed in parentheses > > #456: FILE: drivers/pinctrl/tegra/pinctrl-tegra-io-pad.c:382: > > I can fix this but will still have the error as: > > CHECK: Macro argument reuse '_entry_' - possible side-effects? > #425: FILE: drivers/pinctrl/tegra/pinctrl-tegra-io-pad.c:425: > > > And there is no better way to fix this. It's a stupid little script, feel free to ignore it.
Powered by blists - more mailing lists