linux-kernel - Re: [PATCH 1/5] power: supply: tps65217: Move IRQ related operation into single function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161122165606.jwx5he6tbnv2y7ad@earth>
Date:   Tue, 22 Nov 2016 17:56:06 +0100
From:   Sebastian Reichel <sre@...nel.org>
To:     Milo Kim <woogyom.kim@...il.com>
Cc:     Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] power: supply: tps65217: Move IRQ related operation
 into single function

Hi,

On Tue, Nov 22, 2016 at 05:49:11PM +0100, Sebastian Reichel wrote:
> On Tue, Nov 15, 2016 at 10:18:51PM +0900, Milo Kim wrote:
> > TPS65217 charger driver handles the charger interrupt through the IRQ or
> > polling. Both cases can be requested in single function.
> > 
> > Cc: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> > Signed-off-by: Milo Kim <woogyom.kim@...il.com>
> > ---
> >  drivers/power/supply/tps65217_charger.c | 70 ++++++++++++++++++---------------
> >  1 file changed, 38 insertions(+), 32 deletions(-)
> 
> I don't see the advantage of this. It's more lines of codes than
> before and does not really increase readability.

Ok it makes sense with changes from PATCH 3. Please add a note to
the commit description, that this prep-work for introducing more
irqs.

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)