linux-kernel - Re: [PATCH v6 2/2] Input: synaptics-rmi4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161123095605.GB4833@lava.h.shmanahar.org>
Date:   Wed, 23 Nov 2016 09:56:05 +0000
From:   Nick Dyer <nick@...anahar.org>
To:     Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     Andrew Duggan <aduggan@...aptics.com>,
        Chris Healy <cphealy@...il.com>,
        Henrik Rydberg <rydberg@...math.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 2/2] Input: synaptics-rmi4 - add support for F34 V7
 bootloader

On Tue, Nov 22, 2016 at 05:51:11PM -0800, Dmitry Torokhov wrote:
> On Sun, Nov 20, 2016 at 07:04:02PM +0000, Nick Dyer wrote:
> > +			/* query 7 */
> > +			unsigned char f34_query7_b0:1;
> > +			unsigned char has_bootloader:1;
> > +			unsigned char has_device_config:1;
> > +			unsigned char has_flash_config:1;
> > +			unsigned char has_manufacturing_block:1;
> > +			unsigned char has_guest_serialization:1;
> > +			unsigned char has_global_parameters:1;
> > +			unsigned char has_core_code:1;
> > +			unsigned char has_core_config:1;
> > +			unsigned char has_guest_code:1;
> > +			unsigned char has_display_config:1;
> > +			unsigned char f34_query7_b11__15:5;
> > +			unsigned char f34_query7_b16__23;
> > +			unsigned char f34_query7_b24__31;
> 
> I see bitfields and I think this is not going to work on big endian
> arches because unfortunately they "fill" the bytes with bits in opposite
> order.
> 
> We had to rework old Unixsphere code to get rid of bitfields for on-wire
> data; this seems to be coming from that code base as well and so needs
> to be reworked too.

Hi Dmitry-

Thanks - that makes sense. I will rework this bit to remove the
bitfields.

cheers

Nick