linux-kernel - Re: [PATCH] cpufreq: schedutil: Rectify comment in sugov_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161124084536.GA17988@gmail.com>
Date:   Thu, 24 Nov 2016 09:45:36 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     Rafael Wysocki <rjw@...ysocki.net>, Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        linaro-kernel@...ts.linaro.org, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Vincent Guittot <vincent.guittot@...aro.org>
Subject: Re: [PATCH] cpufreq: schedutil: Rectify comment in sugov_irq_work()
 function


* Viresh Kumar <viresh.kumar@...aro.org> wrote:

> This patch rectifies a comment present in sugov_irq_work() function to
> follow proper grammar.
> 
> Suggested-by: Ingo Molnar <mingo@...nel.org>
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>
> ---
>  kernel/sched/cpufreq_schedutil.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
> index 42a220e78f00..71e1a980d40a 100644
> --- a/kernel/sched/cpufreq_schedutil.c
> +++ b/kernel/sched/cpufreq_schedutil.c
> @@ -315,15 +315,15 @@ static void sugov_irq_work(struct irq_work *irq_work)
>  	sg_policy = container_of(irq_work, struct sugov_policy, irq_work);
>  
>  	/*
> +	 * For Real Time and Deadline tasks, the schedutil governor shoots the
> +	 * frequency to maximum. Special care must be taken to ensure that this
> +	 * kthread doesn't result in the same behavior.
>  	 *
>  	 * This is (mostly) guaranteed by the work_in_progress flag. The flag is
> +	 * updated only at the end of the sugov_work() function and before that
> +	 * the schedutil governor rejects all other frequency scaling requests.
>  	 *
> +	 * There is a very rare case though, where the RT thread yields right
>  	 * after the work_in_progress flag is cleared. The effects of that are
>  	 * neglected for now.
>  	 */

Also:

  s/Real Time task/RT task
  s/Deadline task/deadline task

With those:

  Acked-by: Ingo Molnar <mingo@...nel.org>

Thanks,

	Ingo