linux-kernel - Re: [PATCH v6 4/9] tpm: drop tpm1_chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161124115128.phhd67edwehipkgk@intel.com>
Date:   Thu, 24 Nov 2016 13:51:28 +0200
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Jason Gunthorpe <jgunthorpe@...idianresearch.com>
Cc:     Nayna Jain <nayna@...ux.vnet.ibm.com>,
        tpmdd-devel@...ts.sourceforge.net, peterhuewe@....de,
        tpmdd@...horst.net, linux-kernel@...r.kernel.org,
        linux-security-module@...r.kernel.org
Subject: Re: [PATCH v6 4/9] tpm: drop tpm1_chip_register(/unregister)

On Tue, Nov 22, 2016 at 09:42:40AM -0700, Jason Gunthorpe wrote:
> On Tue, Nov 22, 2016 at 01:22:00PM +0200, Jarkko Sakkinen wrote:
> > On Mon, Nov 14, 2016 at 05:00:51AM -0500, Nayna Jain wrote:
> > > Check for TPM2 chip in tpm_sysfs_add_device, tpm_bios_log_setup and
> > > tpm_bios_log_teardown in order to make code flow cleaner and to enable
> > > to implement TPM 2.0 support later on. This is partially derived from
> > > the commit by Nayna Jain with the extension that also tpm1_chip_register
> > > is dropped.
> > > 
> > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> > 
> > This commit remains unreviewed and tested. I'm in the author role here
> > so I cannot help with this. If that does not happen soon I cannot put
> > this into the pull request.
> 
> I tested it on my ARM system when I tested your branch.
> 
> I think it looks better this way..
> 
> Reviewed-by: Jason Gunthorpe <jgunthorpe@...idianresearch.com>

Thanks. I'll also add tested-by from you then.

/Jarkko