linux-kernel - Re: [PATCH] regulator: twl6030: add dependency on OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161125130337.lf33cysb4cyq6axl@sirena.org.uk>
Date:   Fri, 25 Nov 2016 13:03:37 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Nicolae Rosia <Nicolae_Rosia@...tor.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Tony Lindgren <tony@...mide.com>, linux-omap@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: twl6030: add dependency on OF

On Fri, Nov 25, 2016 at 09:43:35AM +0200, Nicolae Rosia wrote:

> This driver was converted to device tree only,
> add dependency on OF symbol and drop of_match_ptr

These are two different changes :(

>  config REGULATOR_TWL4030
>  	tristate "TI TWL4030/TWL5030/TWL6030/TPS659x0 PMIC"
>  	depends on TWL4030_CORE
> +	depends on OF

This should be OF || COMPILE_TEST so people can still get build coverage
without DT.

> --- a/drivers/regulator/twl6030-regulator.c
> +++ b/drivers/regulator/twl6030-regulator.c
> @@ -773,7 +773,7 @@ static struct platform_driver twlreg_driver = {
>  	 */
>  	.driver  = {
>  		.name  = "twl6030_reg",
> -		.of_match_table = of_match_ptr(twl_of_match),
> +		.of_match_table = twl_of_match,

This buys us nothing, it's not going to make any practical difference
but on the other hand it costs nothing to have it there either.  The
only impact I can see this having is causing someone doing a cut'n'paste
to miss the of_match_ptr() out.

Download attachment "signature.asc" of type "application/pgp-signature" (456 bytes)