linux-kernel - Re: [PATCH] regulator: twl6030: add dependency on OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 25 Nov 2016 13:17:55 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Nicolae Rosia <nicolae.rosia.oss@...il.com>
Cc:     Nicolae Rosia <Nicolae_Rosia@...tor.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Tony Lindgren <tony@...mide.com>, linux-omap@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: twl6030: add dependency on OF

On Fri, Nov 25, 2016 at 03:09:43PM +0200, Nicolae Rosia wrote:
> On Fri, Nov 25, 2016 at 3:03 PM, Mark Brown <broonie@...nel.org> wrote:

> >> -             .of_match_table = of_match_ptr(twl_of_match),
> >> +             .of_match_table = twl_of_match,

> > This buys us nothing, it's not going to make any practical difference
> > but on the other hand it costs nothing to have it there either.  The
> > only impact I can see this having is causing someone doing a cut'n'paste
> > to miss the of_match_ptr() out.

> I did this because I received a comment on another patch [0].

OK, but that still doesn't really explain what the benefit is!

Download attachment "signature.asc" of type "application/pgp-signature" (456 bytes)