linux-kernel - Re: [PATCH] ARM: dts: sunxi: Add num-cs for A20 spi nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161125152047.oadxi2xbgm4kdd7q@lukather>
Date:   Fri, 25 Nov 2016 16:20:47 +0100
From:   Maxime Ripard <maxime.ripard@...e-electrons.com>
To:     Emmanuel Vadot <manu@...ouilliste.com>
Cc:     mark.rutland@....com, devicetree@...r.kernel.org,
        linux@...linux.org.uk, linux-kernel@...r.kernel.org, wens@...e.org,
        robh+dt@...nel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ARM: dts: sunxi: Add num-cs for A20 spi nodes

On Thu, Nov 24, 2016 at 09:05:09PM +0100, Emmanuel Vadot wrote:
> On Thu, 24 Nov 2016 20:55:17 +0100
> Maxime Ripard <maxime.ripard@...e-electrons.com> wrote:
> 
> > On Tue, Nov 22, 2016 at 06:06:16PM +0100, Emmanuel Vadot wrote:
> > > The spi0 controller on the A20 have up to 4 CS (Chip Select) while the
> > > others three only have 1.
> > > Add the num-cs property to each node.
> > > 
> > > Signed-off-by: Emmanuel Vadot <manu@...ouilliste.com>
> > 
> > I don't think we have any code that uses it at the moment. What is the
> > rationale behind this patch?
> > 
> > Thanks!
> > Maxime
> > 
> > -- 
> > Maxime Ripard, Free Electrons
> > Embedded Linux and Kernel engineering
> > http://free-electrons.com
> 
>  Hi Maxime,
> 
>  If num-cs isn't present nothing prevent to start a transfer with a
> non-valid CS pin, resulting in an error.
>  num-cs are default property especially made for this and a SPI driver
> should try to get the property at probe/attach time.

Yes, but as far as I know, our driver doesn't. I'm all in for having
support for that in our driver, but without it, that patch is kind of
useless.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)