linux-kernel - Re: [PATCH RFC] hlist_add_tail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20161125.195223.1182462379062736127.davem@davemloft.net>
Date:   Fri, 25 Nov 2016 19:52:23 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     mst@...hat.com
Cc:     paulmck@...ux.vnet.ibm.com, arnd@...db.de,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC] hlist_add_tail_rcu disable sparse warning

From: "Michael S. Tsirkin" <mst@...hat.com>
Date: Wed, 23 Nov 2016 22:48:19 +0200

> I would appreciate review to confirm the function doesn't
> do anything unsafe though.
> 
> In particular, should this use __hlist_for_each_rcu instead?
> I note that __hlist_for_each_rcu does rcu_dereference
> internally, which is missing here.

I personally think it should use __hlist_for_each_rcu, otherwise
nothing expresses the rcu-ness of the operation.