linux-kernel - Re: [PATCH] drm: bridge: dw-hdmi: add ASoC dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Nov 2016 01:07:54 +0000
From:   Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     Archit Taneja <architt@...eaurora.org>,
        David Airlie <airlied@...ux.ie>,
        Inki Dae <inki.dae@...sung.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Andrzej Hajda <a.hajda@...sung.com>,
        <dri-devel@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm: bridge: dw-hdmi: add ASoC dependency


Hi

> The newly added sound driver depends on SND_SOC_HDMI_CODEC, which in
> turn only makes sense when ASoC is enabled, as shown by this warning:
> 
> warning: (DRM_MSM && DRM_STI && DRM_MEDIATEK_HDMI && DRM_I2C_NXP_TDA998X && DRM_DW_HDMI_I2S_AUDIO) selects SND_SOC_HDMI_CODEC which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC)
> 
> Since the audio driver is probably useless without the audio subsystem,
> adding a dependency here seems the right solution.
> 
> Fixes: 2761ba6c0925 ("drm: bridge: add DesignWare HDMI I2S audio support")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>

>  drivers/gpu/drm/bridge/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 4980ecc55721..71db3e659be9 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -41,6 +41,7 @@ config DRM_DW_HDMI_AHB_AUDIO
>  
>  config DRM_DW_HDMI_I2S_AUDIO
>  	tristate "Synopsis Designware I2S Audio interface"
> +	depends on SND_SOC
>  	depends on DRM_DW_HDMI
>  	select SND_SOC_HDMI_CODEC
>  	help
> -- 
> 2.9.0
> 


Best regards
---
Kuninori Morimoto