linux-kernel - Re: [PATCH] drm: bridge: dw-hdmi: add ASoC dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <29a05ff5-5479-91c1-23e5-dfaba6fb9bd3@codeaurora.org>
Date:   Mon, 28 Nov 2016 14:13:10 +0530
From:   Archit Taneja <architt@...eaurora.org>
To:     Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Arnd Bergmann <arnd@...db.de>
Cc:     David Airlie <airlied@...ux.ie>, Inki Dae <inki.dae@...sung.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Andrzej Hajda <a.hajda@...sung.com>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: bridge: dw-hdmi: add ASoC dependency



On 11/28/2016 06:37 AM, Kuninori Morimoto wrote:
>
> Hi
>
>> The newly added sound driver depends on SND_SOC_HDMI_CODEC, which in
>> turn only makes sense when ASoC is enabled, as shown by this warning:
>>
>> warning: (DRM_MSM && DRM_STI && DRM_MEDIATEK_HDMI && DRM_I2C_NXP_TDA998X && DRM_DW_HDMI_I2S_AUDIO) selects SND_SOC_HDMI_CODEC which has unmet direct dependencies (SOUND && !M68K && !UML && SND && SND_SOC)
>>
>> Since the audio driver is probably useless without the audio subsystem,
>> adding a dependency here seems the right solution.
>>
>> Fixes: 2761ba6c0925 ("drm: bridge: add DesignWare HDMI I2S audio support")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> ---
>
> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>


Added to drm-misc-next

Thanks for fixing this.

Archit

>
>>  drivers/gpu/drm/bridge/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
>> index 4980ecc55721..71db3e659be9 100644
>> --- a/drivers/gpu/drm/bridge/Kconfig
>> +++ b/drivers/gpu/drm/bridge/Kconfig
>> @@ -41,6 +41,7 @@ config DRM_DW_HDMI_AHB_AUDIO
>>
>>  config DRM_DW_HDMI_I2S_AUDIO
>>  	tristate "Synopsis Designware I2S Audio interface"
>> +	depends on SND_SOC
>>  	depends on DRM_DW_HDMI
>>  	select SND_SOC_HDMI_CODEC
>>  	help
>> --
>> 2.9.0
>>
>
>
> Best regards
> ---
> Kuninori Morimoto
>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project