linux-kernel - Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break' statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <583C49EA.5060504@linux.intel.com>
Date:   Mon, 28 Nov 2016 17:14:50 +0200
From:   Mathias Nyman <mathias.nyman@...ux.intel.com>
To:     Baolin Wang <baolin.wang@...aro.org>,
        Greg KH <gregkh@...uxfoundation.org>
Cc:     mathias.nyman@...el.com, USB <linux-usb@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Mark Brown <broonie@...nel.org>
Subject: Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break'
 statement

On 28.11.2016 09:41, Baolin Wang wrote:
> On 28 November 2016 at 15:21, Greg KH <gregkh@...uxfoundation.org> wrote:
>> On Mon, Nov 28, 2016 at 02:29:25PM +0800, Baolin Wang wrote:
>>> Hi Mathias,
>>>
>>> On 24 November 2016 at 19:16, Baolin Wang <baolin.wang@...aro.org> wrote:
>>>> Since these 'return' statements are not generally useful in void
>>>> function, remove them. Also remove one unuseful 'break' statement
>>>> in xhci_setup_addressable_virt_dev() function.
>>>>
>>>> Signed-off-by: Baolin Wang <baolin.wang@...aro.org>
>>>> ---
>>>> Changes since v1:
>>>>   - Add description of removing 'break' statement in commitlog.
>>>> ---
>>>
>>> Could you apply this patch if there are no other comments? Thanks.
>>
>> Less than a week response for a simple cleanup patch?  Why the rush and
>> pressure?  Relax, this really isn't an important patch...
>
> I am sorry for the pressure, I just thought it is one simple cleanup
> patch. It is okay for me to wait for.
>

Looks ok.

If it applies I'll send it forward to usb-next after 4.10-rc1,
It should end up in 4.11

-Mathias