linux-kernel - Re: [PATCH v2 2/4] sparc64: Migrate hvcons irq to panicked cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7e6a2af2-87b7-f042-cd8a-aabac3b3a80b@oracle.com>
Date:   Mon, 28 Nov 2016 12:33:57 -0600
From:   Vijay Kumar <vijay.ac.kumar@...cle.com>
To:     David Miller <davem@...emloft.net>
Cc:     sparclinux@...r.kernel.org, karl.volz@...cle.com,
        rob.gardner@...cle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/4] sparc64: Migrate hvcons irq to panicked cpu


On 11/19/2016 9:48 AM, David Miller wrote:
> From: Vijay Kumar <vijay.ac.kumar@...cle.com>
> Date: Fri, 11 Nov 2016 10:11:57 -0800
>
>> @@ -1444,8 +1444,12 @@ void smp_send_stop(void)
>>   	int cpu;
>>   
>>   	if (tlb_type == hypervisor) {
>> +		int this_cpu = smp_processor_id();
>> +
>> +		sunhv_migrate_hvcons_irq(this_cpu);
>> +
> You can't unconditionally call into code that might be configured
> out by a Kconfig option, as you are doing here.
>
> If SERIAL_SUNHV=n this change will thus result in a build error.
Thanks for your comment. I will fix this and send revised version of patch.

Thanks,
Vijay