linux-kernel - Re: [PATCH] lockdep: fix report formatting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <46427bf6-94bb-d204-cc9d-79a77b6c9bf7@au1.ibm.com>
Date:   Tue, 29 Nov 2016 18:50:08 +1100
From:   Andrew Donnellan <andrew.donnellan@....ibm.com>
To:     Dmitry Vyukov <dvyukov@...gle.com>, peterz@...radead.org,
        mingo@...hat.com
Cc:     aryabinin@...tuozzo.com, andreyknvl@...gle.com, joe@...ches.com,
        linux-kernel@...r.kernel.org, syzkaller@...glegroups.com
Subject: Re: [PATCH] lockdep: fix report formatting

On 29/11/16 01:24, Dmitry Vyukov wrote:
> Since commit 4bcc595ccd80 ("printk: reinstate KERN_CONT for printing
> continuation lines") printk() requires KERN_CONT to continue log
> messages. Lots of printk() in lockdep.c and print_ip_sym() don't
> have it. As the result lockdep reports are completely messed.
>
> Add missing KERN_CONT and inline print_ip_sym() where necessary.
>
> Without this patch all scripts that parse kernel bug reports
> are broken. So it makes sense to get this into 4.9.

I'm glad someone else is looking at this, I started working on a similar 
patch but haven't quite finished it :)

>
> Cc: aryabinin@...tuozzo.com
> Cc: andreyknvl@...gle.com
> Cc: joe@...ches.com
> Cc: peterz@...radead.org
> Cc: mingo@...hat.com
> Cc: linux-kernel@...r.kernel.org
> Cc: syzkaller@...glegroups.com

Missing Signed-off-by.

FWIW I think the pr_cont() macro looks nicer than printk(KERN_CONT ...).

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@....ibm.com  IBM Australia Limited