linux-kernel - Re: [PATCH v3 4/5] thermal: rockchip: optimize the conversion table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20161130062911.GB28498@localhost.localdomain>
Date:   Tue, 29 Nov 2016 22:29:11 -0800
From:   Eduardo Valentin <edubezval@...il.com>
To:     Caesar Wang <wxt@...k-chips.com>
Cc:     rui.zhang@...el.com, heiko@...ech.de, smbarber@...omium.org,
        briannorris@...omium.org, linux-kernel@...r.kernel.org,
        linux-pm@...r.kernel.org, linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH v3 4/5] thermal: rockchip: optimize the conversion table

Hey,

On Mon, Nov 28, 2016 at 07:12:03PM +0800, Caesar Wang wrote:

<cut>

> +	num = abs(table->id[mid].code - table->id[mid + 1].code);
> +	num *= temp - table->id[mid].temp;
> +	denom = table->id[mid + 1].temp - table->id[mid].temp;


isn't the above 'mid + 1' off-by-one when mid ends being == table.length - 1?

You would be accessing table->id[table.length], which is wrong memory
access, no?