linux-kernel - RE: [PATCH v2] [hv] storvsc: Payload buffer incorrectly sized for 32 bit kernels.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM5PR03MB2490406F1FD55B88E5675486A08C0@DM5PR03MB2490.namprd03.prod.outlook.com>
Date:   Wed, 30 Nov 2016 06:14:56 +0000
From:   KY Srinivasan <kys@...rosoft.com>
To:     Cathy Avery <cavery@...hat.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        "jejb@...ux.vnet.ibm.com" <jejb@...ux.vnet.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC:     "devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>
Subject: RE: [PATCH v2] [hv] storvsc: Payload buffer incorrectly sized for 32
 bit kernels.



> -----Original Message-----
> From: Cathy Avery [mailto:cavery@...hat.com]
> Sent: Wednesday, November 23, 2016 5:47 AM
> To: KY Srinivasan <kys@...rosoft.com>; Haiyang Zhang
> <haiyangz@...rosoft.com>; jejb@...ux.vnet.ibm.com;
> martin.petersen@...cle.com
> Cc: devel@...uxdriverproject.org; linux-kernel@...r.kernel.org; linux-
> scsi@...r.kernel.org
> Subject: [PATCH v2] [hv] storvsc: Payload buffer incorrectly sized for 32 bit
> kernels.
> 
> On a 32 bit kernel sizeof(void *) is not 64 bits as hv_mpb_array
> requires. Also the buffer needs to be cleared or the upper bytes
> will contain junk.
> 
> Suggested-by: Vitaly Kuznetsov <vkuznets@...hat.com>
> Signed-off-by: Cathy Avery <cavery@...hat.com>

Thanks Cathy.

Reviewed-by: K. Y. Srinivasan <kys@...rosoft.com>
> 
> ChangeLog:
> 
> v1) Initial submission
> v2) Remove memset and replace kmalloc with kzalloc.
> ---
>  drivers/scsi/storvsc_drv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
> index 8ccfc9e..05526b7 100644
> --- a/drivers/scsi/storvsc_drv.c
> +++ b/drivers/scsi/storvsc_drv.c
> @@ -1495,9 +1495,9 @@ static int storvsc_queuecommand(struct Scsi_Host
> *host, struct scsi_cmnd *scmnd)
>  	if (sg_count) {
>  		if (sg_count > MAX_PAGE_BUFFER_COUNT) {
> 
> -			payload_sz = (sg_count * sizeof(void *) +
> +			payload_sz = (sg_count * sizeof(u64) +
>  				      sizeof(struct vmbus_packet_mpb_array));
> -			payload = kmalloc(payload_sz, GFP_ATOMIC);
> +			payload = kzalloc(payload_sz, GFP_ATOMIC);
>  			if (!payload)
>  				return SCSI_MLQUEUE_DEVICE_BUSY;
>  		}
> --
> 2.5.0