linux-kernel - Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20161130100145.GF1459@lahna.fi.intel.com>
Date:   Wed, 30 Nov 2016 12:01:45 +0200
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Jacek Anaszewski <j.anaszewski@...sung.com>
Cc:     Peter Rosin <peda@...ntia.se>, Phong Vo <pvo@....com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Richard Purdie <rpurdie@...ys.net>, linux-leds@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
        Loc Ho <lho@....com>, Thang Nguyen <tqnguyen@....com>,
        patches <patches@....com>, Tin Huynh <tnhuynh@....com>
Subject: Re: [PATCH V3] leds: pca955x: Add ACPI support for pca955x

On Wed, Nov 30, 2016 at 10:58:33AM +0100, Jacek Anaszewski wrote:
> It certainly downgrades code readability, but in case there is
> similar surrounding code there are two options to keep the things
> consistent - either stick to the current style or change it.
> IMHO the latter would generate only unnecessary noise in this
> particular case.

Also that's the style we have been using when adding ACPI support to
drivers.